Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a utility to get/fetch a user and use it when closing pending threads. #3105

Merged
merged 4 commits into from
Nov 19, 2021

Conversation

Qwerty-133
Copy link
Contributor

Closes #3104.

I noticed we frequently use something like bot.get_user(id) or await bot.fetch_user(id) and extracted that to a utility function to avoid repetition and keep stuff tidy.

@Qwerty-133
Copy link
Contributor Author

I've gone ahead and added the utility as a method on the bot instead.

@fourjr fourjr changed the base branch from master to development November 19, 2021 08:01
Copy link
Collaborator

@fourjr fourjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fourjr fourjr added the staged Staged for next version label Nov 19, 2021
@fourjr fourjr merged commit 3a774d8 into modmail-dev:development Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staged Staged for next version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Failing to account for get_user returning None.
2 participants